chore: explicitly import CurveTrait
for sub
trait method and remove some default implementations
#20
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem
Noir will soon require trait methods to be in scope to be used.
In this test this line:
uses the
sub
method for theCurveTrait
. Because there's alsosub
fromstd::ops::Sub
, Noir now doesn't know which one to use. This PR will fix it for the upcoming release.Summary
In addition to using that import, I removed the default implementations of
add
and others because those are defined separately, and those default implementations will error once noir-lang/noir#6645 is merged.Additional Context
For now this will produce a warning, but I guess it's fine (it will be gone when this feature is released)
PR Checklist
cargo fmt
on default settings.