chore: added simple benchmarks and tooling #100
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
January 16, 2025 13:05
kashbrti
changed the title
TomAFrench
reviewed
Jan 16, 2025
| let c = a - b; | ||
| } | ||
|
|
||
| fn bench_mul<let N: u32, BN>(a: BN, b: BN) |
There was a problem hiding this comment.
I'm not clear on why we need these functions rather than putting the arithmetic directly inside the #[export] functions?
There was a problem hiding this comment.
for these, it doesn't matter much I guess, but I thought it might be a good framework for more complicated functions.
There was a problem hiding this comment.
wonder if this introduces unnecessary memory gates for bb though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Resolves
Summary*
Additional Context
PR Checklist*
cargo fmton default settings.