Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat(acir)!: Add Keccak256 Opcode #91

Merged
merged 1 commit into from
Feb 14, 2023
Merged

feat(acir)!: Add Keccak256 Opcode #91

merged 1 commit into from
Feb 14, 2023

Conversation

kevaundray
Copy link
Contributor

Related issue(s)

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves #90

Description

Keccak256 looks exactly the same as Blake256 and Sha256 from an opcode perspective, so it was mostly just giving it an opcode number and copying the function definition from sha256

Summary of changes

(Describe the changes in this PR. Point out breaking changes if any.)

Dependency additions / changes

(If applicable.)

Test additions / changes

(If applicable.)

Checklist

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt with default settings.
  • I have linked this PR to the issue(s) that it resolves.
  • I have reviewed the changes on GitHub, line by line.
  • I have ensured all changes are covered in the description.

Additional context

(If applicable.)

@phated phated changed the title feat!(acir): Add Keccak256 Opcode feat(acir)!: Add Keccak256 Opcode Feb 13, 2023
@kevaundray kevaundray merged commit b909146 into master Feb 14, 2023
@kevaundray kevaundray deleted the kw/add-keccak256 branch February 14, 2023 18:01
@github-actions github-actions bot mentioned this pull request Feb 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Keccak256 Opcode
2 participants