This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
chore!: Reorganise compiler in terms of optimisers and transformers #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passes that are required for a circuit to usable, rather than just for improving performance, are now called transformers instead of optimisations. Transforms: fallback r1cs csat Optimisations: general more to come General optimising is now separated into its own pass instead of being executed by r1cs of csat. As a result the r1cs pass current has no work to perform.
kevaundray
changed the title
|
I really like this reorganisation of the compiler, I'm happy to fix the merge conflicts caused by adding spellcheck. Are there any blockers for this PR after that? |
TomAFrench
changed the title
5 tasks
Not to my knowledge, though I expect this merge will cause conflicts on other branches under review. |
|
closing as #88 has been merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue(s)
Resolves #59
Description
Summary of changes
Passes that are required for a circuit to be usable--rather than just for improving performance--are now called transformers instead of optimisations.
Transforms:
Optimisations:
General optimising is now separated into its own pass instead of being executed by r1cs of csat. As a result the r1cs pass current has no work to perform.
Checklist
cargo fmtwith default settings.