chore!: refactor ToRadix to ToRadixLe and ToRadixBe

[Ethan-000]

Related issue(s)

(If it does not already exist, first create a GitHub issue that describes the problem this Pull Request (PR) solves before creating the PR and link it here.)

Resolves #57

Description

refactor ToRadix to ToRadixLe and ToRadixBe

Summary of changes

The only key change is here https://github.com/Ethan-000/acvm/blob/2d1fdf892114e571a39713be172977dfadbeca22/acvm/src/pwg/directives.rs#L99

(Describe the changes in this PR. Point out breaking changes if any.)

Dependency additions / changes

(If applicable.)

Test additions / changes

add test to ToRadixRe similar to the others

(If applicable.)

Checklist

• I have tested the changes locally.
• I have formatted the changes with Prettier and/or cargo fmt with default settings.
• I have linked this PR to the issue(s) that it resolves.
• I have reviewed the changes on GitHub, line by line.
• I have ensured all changes are covered in the description.

Additional context

(If applicable.)

[vezenovm]

Thank you for this PR! Left one minor style comment to try out

[vezenovm]

I actually did not mean to approve yet I hope this dismisses

[vezenovm]

I am thinking it would be nicer to actually not have two separate enums for ToRadix.

Let's switch to something like this:

        Directive::ToRadix { a, b, radix, is_little_endian } => {
            let val_a = get_value(a, initial_witness)?;

            let a_big = BigUint::from_bytes_be(&val_a.to_be_bytes());
            let a_dec = if is_little_endian {
               a_big.to_radix_le(*radix)
            } else {
               a_big.to_radix_be(*radix)
            }
            match to_radix_outcome(b, &a_dec, initial_witness) {
                Ok(()) => Ok(()),
                Err(e) => Err(e),
            }
        }

[vezenovm]

One nit pick comment. Once the minor merge conflicts are fixed this looks good to me :)

[kevaundray]

I have a few nits, but I appreciate how long this PR has been up so will address these in a separate PR. Btw Thank you for fixing this issue Ethan, your efforts are really appreciated :)

[Ethan-000]

Thank you guys for reviewing it 🙂!! Suggestions on details are very much welcome cus sometimes I wasn't paying attention and it helps me write better code. I didn't really notice for loop and if don't need ; for example