Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

chore: add ci for acvmjs rust test #516

Merged
merged 21 commits into from
Sep 4, 2023
Merged

chore: add ci for acvmjs rust test #516

merged 21 commits into from
Sep 4, 2023

Conversation

jonybur
Copy link
Contributor

@jonybur jonybur commented Sep 1, 2023

Description

Problem*

Runs cargo test for acvm js

Resolves (#475)

Summary*

Adds a job in the testing workflow and a script in acvmjs's package.json to run cargo test. This could also be done by doing the test via nix flake.

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@jonybur jonybur marked this pull request as ready for review September 1, 2023 12:14
@jonybur jonybur linked an issue Sep 1, 2023 that may be closed by this pull request
Copy link
Member

@TomAFrench TomAFrench left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need to build the TS package in order to test the rust code. We should be able to run this in parallel with build-acvm-js-package and remove all the yarn code.

acvm_js/package.json Outdated Show resolved Hide resolved
@jonybur jonybur added this pull request to the merge queue Sep 4, 2023
Merged via the queue into master with commit 675753c Sep 4, 2023
15 checks passed
@jonybur jonybur deleted the jb/ci-test branch September 4, 2023 11:21
TomAFrench added a commit that referenced this pull request Sep 15, 2023
* master: (40 commits)
  chore: make acvm_js publish trigger on release-please (#550)
  chore(ci): add `cargo deny` workflow (#549)
  fix: use the exact version for the hex crate (#546)
  chore: Release 0.26.1 (#542)
  fix: Implements handling of the high limb during fixed base scalar multiplication (#535)
  chore: fix acvm publishing (#539)
  chore: fix wasm build on macos (#541)
  chore(ci): install `wasm-bindgen-cli` through prebuilt binary (#536)
  chore: add manual trigger to acvm_js publishing (#534)
  chore: acvm_js publishing (#529)
  chore: Release 0.26.0 (#533)
  chore!: Add a low and high limb to scalar mul opcode (#532)
  chore: Release 0.25.0 (#526)
  fix: initialize recursive proof output to zero (#524)
  chore(ci): update to actions/checkout@v4 (#525)
  feat!: Provide runtime callstacks for brillig failures and return errors in acvm_js (#523)
  chore: add ci for acvmjs rust test (#516)
  chore: Release 0.24.1 (#519)
  fix: Add WASI 20 `_initialize` call to `acvm_backend.wasm` binary (#518)
  chore: Release 0.24.0 (#512)
  ...
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add CI to run cargo test on acvm_js
2 participants