This repository has been archived by the owner on Apr 9, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
reviewed
Sep 1, 2023
TomAFrench
suggested changes
Sep 1, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't need to build the TS package in order to test the rust code. We should be able to run this in parallel with build-acvm-js-package
and remove all the yarn code.
TomAFrench
reviewed
Sep 4, 2023
TomAFrench
reviewed
Sep 4, 2023
TomAFrench
reviewed
Sep 4, 2023
TomAFrench
approved these changes
Sep 4, 2023
TomAFrench
reviewed
Sep 4, 2023
TomAFrench
added a commit
that referenced
this pull request
Sep 15, 2023
* master: (40 commits) chore: make acvm_js publish trigger on release-please (#550) chore(ci): add `cargo deny` workflow (#549) fix: use the exact version for the hex crate (#546) chore: Release 0.26.1 (#542) fix: Implements handling of the high limb during fixed base scalar multiplication (#535) chore: fix acvm publishing (#539) chore: fix wasm build on macos (#541) chore(ci): install `wasm-bindgen-cli` through prebuilt binary (#536) chore: add manual trigger to acvm_js publishing (#534) chore: acvm_js publishing (#529) chore: Release 0.26.0 (#533) chore!: Add a low and high limb to scalar mul opcode (#532) chore: Release 0.25.0 (#526) fix: initialize recursive proof output to zero (#524) chore(ci): update to actions/checkout@v4 (#525) feat!: Provide runtime callstacks for brillig failures and return errors in acvm_js (#523) chore: add ci for acvmjs rust test (#516) chore: Release 0.24.1 (#519) fix: Add WASI 20 `_initialize` call to `acvm_backend.wasm` binary (#518) chore: Release 0.24.0 (#512) ...
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Problem*
Runs cargo test for acvm js
Resolves (#475)
Summary*
Adds a job in the testing workflow and a script in acvmjs's package.json to run cargo test. This could also be done by doing the test via nix flake.
PR Checklist*
cargo fmt
on default settings.