Skip to content
This repository has been archived by the owner on Apr 9, 2024. It is now read-only.

feat!: Assertion messages embedded in the circuit #484

Merged
merged 13 commits into from
Aug 30, 2023
Merged

feat!: Assertion messages embedded in the circuit #484

merged 13 commits into from
Aug 30, 2023

Conversation

sirasistant
Copy link
Contributor

@sirasistant sirasistant commented Aug 11, 2023 •
edited
Loading

Description

Problem*

Resolves ACVM part of noir-lang/noir#1939

Summary*

Additional Context

PR Checklist*

  • I have tested the changes locally.
  • I have formatted the changes with Prettier and/or cargo fmt on default settings.

@TomAFrench
Copy link
Member

TomAFrench commented Aug 11, 2023 •
edited
Loading

Note that this is a breaking PR for the serialization so we're going to need to go through the full updates to barretenberg, etc, etc.

Just to emphasise, this will be a massive pain to deal with so this should not get rolled into a release ASAP as we have other serialisation changes to make.

@sirasistant sirasistant changed the title WIP: assertion messages embedded in the circuit feat!: Assertion messages embedded in the circuit Aug 21, 2023
@sirasistant sirasistant marked this pull request as ready for review August 21, 2023 08:47
TomAFrench
TomAFrench suggested changes Aug 21, 2023
View reviewed changes
acvm/src/pwg/mod.rs Outdated Show resolved Hide resolved
@sirasistant sirasistant mentioned this pull request Aug 25, 2023
Closed
@TomAFrench TomAFrench added this pull request to the merge queue Aug 30, 2023
Merged via the queue into master with commit 06b97c5 Aug 30, 2023
13 checks passed
@kevaundray kevaundray mentioned this pull request Aug 30, 2023
Merged
TomAFrench added a commit that referenced this pull request Aug 30, 2023
@TomAFrench
Merge branch 'master' into remove-unused-opcodes
1470b5b 
* master:
  feat(acir)!: Add predicate to MemoryOp (#503)
  chore(acvm)!: Remove unused arguments from `Backend` trait (#511)
  feat!: Assertion messages embedded in the circuit (#484)
Sakapoi pushed a commit to Sakapoi/acvm_fork that referenced this pull request Aug 31, 2023
@sirasistant @Sakapoi
feat!: Assertion messages embedded in the circuit (noir-lang#484)
b262ed5
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kevaundray kevaundray kevaundray approved these changes

@TomAFrench TomAFrench TomAFrench approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sirasistant @TomAFrench @kevaundray