This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
feat!: receive public_inputs when verifying as a BTreeMap [DO NOT MERGE]
#56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TomAFrench
changed the title
public_inputs when verifying as a BTreeMap [DO NOT MERGE]public_inputs when verifying as a BTreeMap [DO NOT MERGE]
|
Closing in favour of #58 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from conversation on Slack, this PR updates the backend to make use of the new interface as defined in noir-lang/acvm#96
The major benefit being that it's now semantically explicit that we're passing witness assignments in here and so duplicate values are impossible.
Something I want to flag up is that I haven't updated
serialise_public_inputsinaztec_backend_wasm. https://github.com/noir-lang/aztec_backend/blob/cff757dca7971161e4bd25e7a744d910c37c22be/aztec_backend_wasm/src/lib.rs#L94The reasoning for this is that we also take a vector for the initial witness in
compute_witnessesso it seems that we want to avoid maps here.