This repository has been archived by the owner on Oct 31, 2023. It is now read-only.
chore: Remove streaming CRS download & indicator #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we'd want something to flag that there's activity even if it's just a spinner, I was on a poor internet connection when downloading SRS to my laptop the first time and having some feedback was helpful. If it helps with getting JS out however I good with dropping it in the short term. We have a lot of conditional compilation already however so I don't think it would be the end of the world to have some here. |
TomAFrench
approved these changes
May 17, 2023
TomAFrench
added a commit
that referenced
this pull request
May 19, 2023
* feat!: update to target acvm-84b5d18d * chore: update to use new black box solver interface * use patch syntax * update to latest changes * feat!: update to acvm with non-homogeneous bb calls (#169) * feat: update acvm * feat!: updated acvm to latest master * chore: update cargo toml * Update src/barretenberg_structures.rs Co-authored-by: Tom French <[email protected]> --------- Co-authored-by: Tom French <[email protected]> * fix bad rebase * feat!: Update backend to rely on WitnessMap (#152) Co-authored-by: Tom French <[email protected]> * update acvm * feat!: Implement CommonReferenceString trait (#139) * chore!: Remove filesystem access and utilize async fetch with range requests Co-authored-by: Tom French <[email protected]> * chore: Switch to tokio test macro for async function (#191) * chore: Remove `sled` & `tempfile` dev-dependencies (#190) * chore: Remove sled & tempfile dev-dependencies * chore: space out functions --------- Co-authored-by: Tom French <[email protected]> * chore: bump to crates.io release * Update src/crs.rs * chore: Remove streaming CRS download & indicator (#194) * Update src/acvm_interop/common_reference_string.rs * code review --------- Co-authored-by: Blaine Bublitz <[email protected]> Co-authored-by: Álvaro Rodríguez <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the streaming download of the CRS bytes and removes the indicator about how much is downloaded.
Since we are now adjusting our download on circuit size (and growing the CRS as a circuit grows), the backend will no longer be downloading 307mb in one single download. This was making the indicator go from 0 to complete instantly, which looks strange.
Additionally, this sets us up to use the same download function both natively and in JS.