forked from apache/gravitino
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[apache#3203] improvement(PyClient): Add pylint Rules for Python clie…
…nt (apache#3204) ### What changes were proposed in this pull request? * Add pylint rule for logging, logging should use old format (%), not fstring * Unify all the logging format * Set many disable rules for future modification (I add TODO tags after them, will work on them after this PR) ### Why are the changes needed? Fix: apache#3203 ### Does this PR introduce _any_ user-facing change? No ### How was this patch tested? ```bash ./gradlew :clients:client-python:test ``` --------- Co-authored-by: TimWang <[email protected]>
- Loading branch information
1 parent
6bed32b
commit 91d91c0
Showing
21 changed files
with
113 additions
and
58 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -5,5 +5,7 @@ | |
**/__pycache__/** | ||
gravitino.egg-info | ||
vevn | ||
venv | ||
.vevn | ||
.venv | ||
.idea |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,55 @@ | ||
# Copyright 2024 Datastrato Pvt Ltd. | ||
# This software is licensed under the Apache License version 2. | ||
|
||
[MESSAGES CONTROL] | ||
|
||
# Only show warnings with the listed confidence levels. Leave empty to show | ||
# all. Valid levels: HIGH, INFERENCE, INFERENCE_FAILURE, UNDEFINED. | ||
confidence= | ||
|
||
# Enable the message, report, category or checker with the given id(s). | ||
# enable=logging | ||
|
||
# Disable the message, report, category or checker with the given id(s). | ||
disable=missing-class-docstring, | ||
missing-function-docstring, | ||
missing-module-docstring, | ||
global-variable-not-assigned, | ||
too-many-public-methods, | ||
too-few-public-methods, | ||
unused-argument, | ||
no-else-break, | ||
no-member, | ||
fixme, | ||
unnecessary-pass, | ||
missing-timeout, #TODO-fix | ||
redefined-builtin, #TODO-fix | ||
broad-exception-caught, #TODO-fix | ||
duplicate-code, #TODO-fix | ||
method-hidden, #TODO-fix | ||
no-name-in-module, #TODO-fix | ||
invalid-field-call, #TODO-fix | ||
protected-access, #TODO-fix | ||
too-many-arguments, #TODO-fix | ||
inconsistent-return-statements, #TODO-fix | ||
line-too-long, #TODO-config | ||
invalid-name, #TODO-config | ||
trailing-whitespace, #TODO-config | ||
missing-final-newline #TODO-config | ||
|
||
[LOGGING] | ||
|
||
# The type of string formatting that logging methods do. `old` means using % | ||
# formatting, `new` is for `{}` formatting. | ||
logging-format-style=old | ||
|
||
# Logging modules to check that the string format arguments are in logging | ||
# function parameter format. | ||
logging-modules=logging | ||
|
||
[TYPECHECK] | ||
|
||
# List of members which are set dynamically and missed by pylint inference | ||
# system, and so shouldn't trigger E1101 when accessed. Python regular | ||
# expressions are accepted. | ||
generated-members=gravitino.utils.http_client.Response |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,5 @@ | ||
# Copyright 2024 Datastrato Pvt Ltd. | ||
# This software is licensed under the Apache License version 2. | ||
requests | ||
dataclasses-json | ||
dataclasses-json | ||
pylint |
Oops, something went wrong.