Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

unwrap was missing in type defintion #158

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

me23
Copy link

@me23 me23 commented Jun 22, 2020

No description provided.

@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #158 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #158   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines          146       146           
  Branches        37        37           
=========================================
  Hits           146       146           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 496657b...779a832. Read the comment docs.

@aviadhahami
Copy link
Collaborator

@me23 can you add a test for this?

@me23
Copy link
Author

me23 commented May 11, 2023

Hi,
there is a test for unwrap already. The only thing i added was the type-definition for the unwrap, so that typescript won't complain about unknown method unwrap... So i don't think we need another test?!
bye
me23

@aviadhahami
Copy link
Collaborator

@me23 there are plenty of changes in your diff, could u please rebase and check that you only pr the relevant change?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants