Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Line Simplification #52

Open
Mr0grog opened this issue May 13, 2013 · 3 comments
Open

Line Simplification #52

Mr0grog opened this issue May 13, 2013 · 3 comments

Comments

@Mr0grog
Copy link
Member

Mr0grog commented May 13, 2013

Ran across this library the other day: https://github.com/mourner/simplify-js

Could potentially use it to add line simplification as a feature. Not sure how valuable it would be (or the right way to expose it to use).

@bensheldon
Copy link
Member

That would be awesome if we could get it into the data source side. We need to do more profiling, but sadly I think our bottlenecks are in the data connectors rather than our renderer.

On Sun, May 12, 2013 at 10:03 PM, Rob Brackett [email protected]
wrote:

Ran across this library the other day: https://github.com/mourner/simplify-js

Could potentially use it to add line simplification as a feature. Not sure how valuable it would be (or the right way to expose it to use).

Reply to this email directly or view it on GitHub:
#52

@Mr0grog
Copy link
Member Author

Mr0grog commented May 13, 2013

Oh, there's definitely bottlenecks in both ;)

FWIW, the biggest time-sink at the moment is, surprisingly, turning colors (from Carto's AST) into strings! That one is definitely renderer-side. There's also a huge amount of Array.forEach() use in the renderer, which is known to be slow (both for JS/C++ re-entry and for call frame creation). Don't remember off the top of my head what the other standout issues were when I was experimenting with node --prof (which is not friendly) about a month ago.

@Mr0grog
Copy link
Member Author

Mr0grog commented May 13, 2013

That would be awesome if we could get it into the data source side

Also not really sure whether it would belong on the source side or whether the options should be specified via the style sheet (which seems to be a more natural fit, though harder technically to make work).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants