Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parse jsonl files #95

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Parse jsonl files #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions nodestream/pipeline/extractors/files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,11 @@ def read_file_from_handle(self, fp: StringIO) -> Iterable[JsonLikeDocument]:
return [json.load(fp)]


class LineSeperatedJsonFileFormat(SupportedFileFormat, alias=".jsonl"):
def read_file_from_handle(self, fp: StringIO) -> Iterable[JsonLikeDocument]:
return (json.loads(line) for line in fp)


class TextFileFormat(SupportedFileFormat, alias=".txt"):
def read_file_from_handle(self, fp: StringIO) -> Iterable[JsonLikeDocument]:
return ({"line": line} for line in fp)
Expand Down
21 changes: 19 additions & 2 deletions tests/unit/pipeline/extractors/test_files.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@ def json_file(fixture_directory):
yield Path(temp_file.name)


@pytest.fixture
def jsonl_file(fixture_directory):
with NamedTemporaryFile("w+", suffix=".jsonl", dir=fixture_directory) as temp_file:
json.dump(SIMPLE_RECORD, temp_file)
temp_file.write("\n")
json.dump(SIMPLE_RECORD, temp_file)
temp_file.seek(0)
yield Path(temp_file.name)


@pytest.fixture
def csv_file(fixture_directory):
with NamedTemporaryFile("w+", suffix=".csv", dir=fixture_directory) as temp_file:
Expand Down Expand Up @@ -65,9 +75,16 @@ async def test_txt_formatting(txt_file):
assert_that(results, equal_to([{"line": "hello world"}]))


def test_declarative_init(fixture_directory, csv_file, json_file, txt_file):
@pytest.mark.asyncio
async def test_jsonl_formatting(jsonl_file):
subject = FileExtractor([jsonl_file])
results = [r async for r in subject.extract_records()]
assert_that(results, equal_to([SIMPLE_RECORD, SIMPLE_RECORD]))


def test_declarative_init(fixture_directory, csv_file, json_file, txt_file, jsonl_file):
subject = FileExtractor.from_file_data(globs=[f"{fixture_directory}/**"])
assert_that(list(subject.paths), has_length(3))
assert_that(list(subject.paths), has_length(4))


@pytest.mark.asyncio
Expand Down