Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add config in initialization #93

Merged
merged 3 commits into from
Sep 13, 2023
Merged

add config in initialization #93

merged 3 commits into from
Sep 13, 2023

Conversation

grantleehoffman
Copy link
Contributor

@grantleehoffman grantleehoffman commented Sep 13, 2023

  • fix config parsing parameter error when initializing pipeline

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (b0a80bf) 94.52% compared to head (8f0391a) 94.53%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #93   +/-   ##
=======================================
  Coverage   94.52%   94.53%           
=======================================
  Files         123      123           
  Lines        3162     3163    +1     
=======================================
+ Hits         2989     2990    +1     
  Misses        173      173           
Flag Coverage Δ
3.10 94.53% <100.00%> (+<0.01%) ⬆️
3.11 94.53% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nodestream/project/pipeline_definition.py 98.07% <100.00%> (+0.03%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zprobst zprobst merged commit 699427c into main Sep 13, 2023
4 checks passed
@zprobst zprobst deleted the pipeline_config_init_bug branch September 13, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants