Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect filtering logic #89

Merged
merged 2 commits into from
Sep 12, 2023
Merged

Fix incorrect filtering logic #89

merged 2 commits into from
Sep 12, 2023

Conversation

zprobst
Copy link
Contributor

@zprobst zprobst commented Sep 8, 2023

The filter logic was not awaiting the wrong method. Thus everything was not working correctly in the filters. This creates a test for the core logic of a filter and fixes the noted issue.

@zprobst zprobst requested a review from ccloes as a code owner September 8, 2023 16:23
@codecov
Copy link

codecov bot commented Sep 8, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.09% 🎉

Comparison is base (c487e57) 94.38% compared to head (fd5ef96) 94.48%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #89      +/-   ##
==========================================
+ Coverage   94.38%   94.48%   +0.09%     
==========================================
  Files         122      122              
  Lines        3117     3117              
==========================================
+ Hits         2942     2945       +3     
+ Misses        175      172       -3     
Flag Coverage Δ
3.10 94.48% <100.00%> (+0.09%) ⬆️
3.11 94.48% <100.00%> (+0.09%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nodestream/pipeline/filters.py 100.00% <100.00%> (+7.14%) ⬆️

☔ View full report in Codecov by Sentry.

📢 Have feedback on the report? Share it here.

Copy link
Contributor

@ccloes ccloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good... could we also implement a test which tests the "NotImplementedError" part of the logic where the Class is implemented incorrectly? Not sure the value, but just a thought.

@zprobst zprobst merged commit 5d8cf47 into main Sep 12, 2023
4 checks passed
@zprobst
Copy link
Contributor Author

zprobst commented Sep 12, 2023

Looks good... could we also implement a test which tests the "NotImplementedError" part of the logic where the Class is implemented incorrectly? Not sure the value, but just a thought.

That's not a bad idea. I'll create a follow up PR.

@zprobst zprobst deleted the fix/filters-incorrect branch October 12, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants