Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to bound outbox size #78

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Add an option to bound outbox size #78

merged 1 commit into from
Aug 29, 2023

Conversation

zprobst
Copy link
Contributor

@zprobst zprobst commented Aug 29, 2023

The outbox size represents the upper-bound of how many items can be buffered from a step before the step is blocked from continuing. This PR introduces an option to set this value for different performance environments.

@zprobst zprobst requested a review from ccloes as a code owner August 29, 2023 15:21
@codecov
Copy link

codecov bot commented Aug 29, 2023

Codecov Report

Merging #78 (1eab3a2) into main (3d03c54) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main      #78   +/-   ##
=======================================
  Coverage   94.29%   94.29%           
=======================================
  Files         121      121           
  Lines        3065     3067    +2     
=======================================
+ Hits         2890     2892    +2     
  Misses        175      175           
Flag Coverage Δ
3.10 94.29% <100.00%> (+<0.01%) ⬆️
3.11 94.29% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nodestream/cli/commands/run.py 100.00% <ø> (ø)
nodestream/cli/operations/run_pipeline.py 97.50% <ø> (ø)
nodestream/pipeline/pipeline.py 98.48% <100.00%> (+0.02%) ⬆️
nodestream/pipeline/pipeline_file_loader.py 98.36% <100.00%> (+0.02%) ⬆️

@zprobst zprobst merged commit cfcdfd9 into main Aug 29, 2023
4 checks passed
@zprobst zprobst deleted the add-outbox-size-option branch August 29, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants