Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add uvloop #56

Merged
merged 3 commits into from
Aug 15, 2023
Merged

Add uvloop #56

merged 3 commits into from
Aug 15, 2023

Conversation

zprobst
Copy link
Contributor

@zprobst zprobst commented Aug 8, 2023

uvloop makes asyncio must faster than the standard library eventloop. According to their docs, its is at ~2x faster than nodejs and gevent.. The performance of uvloop-based asyncio is close to that of Go programs. Paired with #50 , this should dramatically increase the performance of nodestream.

@zprobst zprobst requested a review from ccloes as a code owner August 8, 2023 17:11
@codecov
Copy link

codecov bot commented Aug 14, 2023

Codecov Report

Merging #56 (67cc289) into main (c434717) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main      #56      +/-   ##
==========================================
- Coverage   93.72%   93.63%   -0.10%     
==========================================
  Files         121      121              
  Lines        3029     3032       +3     
==========================================
  Hits         2839     2839              
- Misses        190      193       +3     
Flag Coverage Δ
3.10 93.63% <0.00%> (-0.10%) ⬇️
3.11 93.63% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nodestream/cli/application.py 0.00% <0.00%> (ø)

@zprobst zprobst merged commit b10fc34 into main Aug 15, 2023
2 of 4 checks passed
@zprobst zprobst deleted the chore/uv-loop branch August 15, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants