Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Schema Generation tests and additional Integration test #51

Merged
merged 6 commits into from
Aug 22, 2023

Conversation

zprobst
Copy link
Contributor

@zprobst zprobst commented Jul 23, 2023

Closes #11
Closes #12

@zprobst zprobst requested a review from ccloes as a code owner July 23, 2023 23:46
@zprobst zprobst marked this pull request as draft July 24, 2023 00:03
@zprobst zprobst marked this pull request as ready for review August 6, 2023 17:44
@codecov
Copy link

codecov bot commented Aug 11, 2023

Codecov Report

Merging #51 (05daf54) into main (0ee9ca8) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main      #51      +/-   ##
==========================================
+ Coverage   93.73%   94.00%   +0.26%     
==========================================
  Files         121      121              
  Lines        3032     3034       +2     
==========================================
+ Hits         2842     2852      +10     
+ Misses        190      182       -8     
Flag Coverage Δ
3.10 94.00% <100.00%> (+0.26%) ⬆️
3.11 94.00% <100.00%> (+0.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
nodestream/cli/operations/print_project_schema.py 100.00% <100.00%> (ø)
nodestream/schema/printers/schema_printer.py 94.44% <100.00%> (+1.11%) ⬆️

... and 4 files with indirect coverage changes

@zprobst zprobst merged commit ea1fffd into main Aug 22, 2023
4 checks passed
@zprobst zprobst deleted the test/additional-integration-tests branch August 22, 2023 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants