Gracefully Close Database Connector #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zprobst
requested changes
Sep 4, 2024
There was a problem hiding this comment.
Thanks for the PR @sophiadt!
I think this approach will work for us. A couple requests:
- Can we add
finishto the ABCs for the executor and the ingest strategies? In the case of the executor I think a reasonable default is to simplypass? - Is it possible to add a test case or two to cover the added lines?
|
I've also approved the CI run. I suspect we may see a linter error or two crop up. |
sophiadt
force-pushed
the
clientReuse
branch
from
f23110f
to
bd9bbd4
Compare
|
Hi @zprobst! |
zprobst
approved these changes
Sep 5, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #364 +/- ##
=======================================
Coverage 97.94% 97.95%
=======================================
Files 147 147
Lines 5307 5319 +12
=======================================
+ Hits 5198 5210 +12
Misses 109 109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wanted a mechanism to properly close the database connector and this PR is chaining the pipeline finish event from the Graph Database Writer all the way down to the database connector.