Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix do_lowercase_strings being applied to everything in SourceNodeInterpretation #342

Merged
merged 2 commits into from
Aug 2, 2024

Conversation

zprobst
Copy link
Contributor

@zprobst zprobst commented Jul 30, 2024

Closes #277

@zprobst zprobst requested a review from ccloes as a code owner July 30, 2024 17:50
@zprobst zprobst changed the base branch from main to 0.13 July 30, 2024 17:50
Copy link

codecov bot commented Jul 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.93%. Comparing base (8dfb14b) to head (435456c).

Additional details and impacted files
@@           Coverage Diff           @@
##             0.13     #342   +/-   ##
=======================================
  Coverage   97.93%   97.93%           
=======================================
  Files         144      144           
  Lines        5122     5127    +5     
=======================================
+ Hits         5016     5021    +5     
  Misses        106      106           
Flag Coverage Δ
3.10-macos-latest 97.91% <100.00%> (+<0.01%) ⬆️
3.10-ubuntu-latest 97.91% <100.00%> (+<0.01%) ⬆️
3.10-windows-latest 97.87% <100.00%> (+<0.01%) ⬆️
3.11-macos-latest 97.91% <100.00%> (+<0.01%) ⬆️
3.11-ubuntu-latest 97.91% <100.00%> (+<0.01%) ⬆️
3.11-windows-latest 97.87% <100.00%> (+<0.01%) ⬆️
3.12-macos-latest 97.91% <100.00%> (+<0.01%) ⬆️
3.12-ubuntu-latest 97.91% <100.00%> (+<0.01%) ⬆️
3.12-windows-latest 97.87% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zprobst zprobst added this to the 0.13.x milestone Aug 1, 2024
@zprobst zprobst merged commit db5e329 into 0.13 Aug 2, 2024
11 checks passed
@zprobst zprobst deleted the fix/properties-interpretation-commands branch August 2, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] do_lowercase_strings is being applied to all property values by default
2 participants