Refactor File Handling Code to Fix S3 Incompatability Issues #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #338 +/- ##
==========================================
+ Coverage 97.88% 97.93% +0.05%
==========================================
Files 144 144
Lines 5142 5122 -20
==========================================
- Hits 5033 5016 -17
+ Misses 109 106 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -27,6 +25,17 @@ def fixture_directory(): | |||
| yield tempdir | |||
|
|
|||
|
|
|||
| @pytest.fixture | |||
| def unspported_file(fixture_directory): | |||
There was a problem hiding this comment.
Oops. I'll patch that un in a follow up PR.
| ) | ||
|
|
||
|
|
||
| class S3Extractor(UnifiedFileExtractor): |
There was a problem hiding this comment.
Without this class specifying the file source is to be an S3FileSource, how would we do:
UnifiedFileExtractor.from_file_data(**s3FileSourceParams) in the future?
There was a problem hiding this comment.
Thats a really good question. I've documented the approach here.
angelosantos4
approved these changes
Jul 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we a complete refactoring to the internals of the file handling logic that allows for increased interoperability and maintainability between file handling logic and sources. To accomplish this, the PR introduces the following changes:
SupportedFileFormatandSupportedCompressedFileFormattoFileCodecandCompressionCodecrespectively to provide a better naming for their changed roles. Now, these types simply provided the decode behaviors and do not own a file in anyway.ReadableFileand its subclasses which define methods for building reader types fromselfas well as defining thepathof the file (which can be a non-real path).FileSourceand its subclasses which essentially work to build instances ofReadableFileand return them to a single unified file extractor behavior.filesmodule.