AWS Credentials Refresh when Not Assuming Roles #335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #335 +/- ##
=======================================
Coverage 97.87% 97.87%
=======================================
Files 144 144
Lines 5136 5141 +5
=======================================
+ Hits 5027 5032 +5
Misses 109 109
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| return boto3.Session(botocore_session=session, **self.session_args).client( | ||
| client_name | ||
| ) | ||
| return boto3.client(client_name, **self.session_args) |
There was a problem hiding this comment.
So this base client will refresh credentials using the user's arn by default?
There was a problem hiding this comment.
Good call. Turns out It will in some cases... but not all: https://boto3.amazonaws.com/v1/documentation/api/latest/guide/credentials.html
I've updated it.
angelosantos4
approved these changes
Jul 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, if we do not assume a role, we grab a basic boto score session which gets the credentials without refreshing. This PR introduces a change to fall back on a regular boto3 session which will fetch again from the provider chain.