ValueProvider errors to have helpful error messages #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yasonk
commented
Jun 26, 2024
| @@ -24,6 +24,9 @@ def many_values(self, _: ProviderContext) -> Iterable[Any]: | |||
| def is_static(self) -> bool: | |||
| return True | |||
|
|
|||
| def __str__(self): | |||
There was a problem hiding this comment.
StaticProvider does not have any posibility of errors in single or many_values methods
yasonk
commented
Jun 26, 2024
| @@ -30,6 +30,9 @@ def many_values(self, context: ProviderContext) -> Iterable[Any]: | |||
| return [] | |||
| return value if isinstance(value, list) else [value] | |||
|
|
|||
| def __str__(self): | |||
There was a problem hiding this comment.
VariableValueProvider does not have any errors that would benefit from anything other than the stack trace, which we already print
|
It's always nice to see additional context in the errors. Looks good to me! |
zprobst
previously approved these changes
Jun 26, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 97.74% 97.75%
=======================================
Files 142 142
Lines 4754 4802 +48
=======================================
+ Hits 4647 4694 +47
- Misses 107 108 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zprobst
approved these changes
Jun 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently errors in value provider of a pipeline do not contain sufficient information. Need to show value provider expression and document in the error log message.
Introducing
__str__method allows for a more readable string representation of ValueProvidersTry and except blocks are added in
single_valueandmany_valuesmethodsupdated tests