Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run Command Improvements #100

Merged
merged 7 commits into from
Oct 11, 2023
Merged

Run Command Improvements #100

merged 7 commits into from
Oct 11, 2023

Conversation

@zprobst zprobst requested a review from ccloes as a code owner October 11, 2023 15:42
@codecov
Copy link

codecov bot commented Oct 11, 2023

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (14f7ed0) 94.53% compared to head (fda406d) 94.47%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #100      +/-   ##
==========================================
- Coverage   94.53%   94.47%   -0.07%     
==========================================
  Files         123      123              
  Lines        3168     3187      +19     
==========================================
+ Hits         2995     3011      +16     
- Misses        173      176       +3     
Flag Coverage Δ
3.10 94.47% <87.50%> (-0.07%) ⬇️
3.11 94.47% <87.50%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
nodestream/cli/commands/run.py 100.00% <100.00%> (ø)
nodestream/cli/commands/shared_options.py 100.00% <100.00%> (ø)
nodestream/project/project.py 89.88% <100.00%> (+0.47%) ⬆️
nodestream/pipeline/pipeline_file_loader.py 97.14% <85.71%> (-1.30%) ⬇️
nodestream/cli/operations/run_pipeline.py 93.75% <83.33%> (-3.75%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ccloes
ccloes previously approved these changes Oct 11, 2023
Copy link
Contributor

@ccloes ccloes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The codecov lines indicate sections which are not covered by tests... kinda cool.

@zprobst zprobst merged commit 42816cb into main Oct 11, 2023
2 of 4 checks passed
@zprobst zprobst deleted the feature/run-command-improvements branch October 12, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants