Move sudo to only where needed to fix proxy issues #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Oct 9, 2014
|
as mentioned in #21 this isn't always going to work, it'll need wide testing across the distros we support (not just Ubuntu with this script) and also good feedback to the user if it fails. |
|
PS.: |
|
sorry for the delay here, I'm going to say no on this one because we do need to document |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I propose moving sudo to only those operations that need it rather than the whole script. This fixes being behind a corporate proxy server configured through environment variables which do not survive "sudo" without -E option. Additionally, if the curl request fails it is nice to see why (with the -S option), since the error message saying the distribution is not supported is misleading in the event of an network error.