Unification of error messages for e2e test #87
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
@lholmquist Please, code review |
lholmquist
reviewed
Mar 22, 2018
app.js
Outdated
| @@ -29,7 +29,7 @@ const db = require('./lib/db'); | |||
|
|
|||
| const fruits = require('./lib/routes/fruits'); | |||
|
|
|||
| app.use(bodyParser.json()); | |||
| app.use(bodyParser.text({ type: 'application/json' })); | |||
There was a problem hiding this comment.
why do you need to do this. isn't this just another way of writing bodyParser.json()?
There was a problem hiding this comment.
Good point. I look at on it.
lholmquist
reviewed
Mar 22, 2018
lib/routes/fruits.js
Outdated
| if (result.rowCount === 0) { | ||
| response.status(404); | ||
| return response.send(`Unknown item ${id}`); | ||
| } | ||
| return response.sendStatus(204); |
There was a problem hiding this comment.
i don't think there is any reason to remove that return . it technically doesn't need to be there, but the other methods have it, so we should keep it for consistency
|
@akoniar once those other issues are fixed, i can probably merge this |
|
@akoniar looks like travis is broken |
|
@akoniar still broken. you should probably run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.