Fixes for persistent postgres example (#230)

* fix: point at the correct spot for pgsql volumes
* check that there is a product table first
* catch error when table hasnn't been created yet

fixes #228

.openshift/postgresql-template-persistent.json

@@ -406,7 +406,7 @@
                 "volumeMounts": [
                   {
                     "name": "${DATABASE_SERVICE_NAME}-data",
-                    "mountPath": "/var/lib/postgresql/data"
+                    "mountPath": "/var/lib/pgsql/data"
                   }
                 ]
               }

lib/db/index.js

@@ -2,16 +2,26 @@
 const { Pool } = require('pg');
 
 const serviceHost = process.env.MY_DATABASE_SERVICE_HOST || process.env.POSTGRESQL_SERVICE_HOST || 'localhost';
-const user = process.env.DB_USERNAME || process.env.POSTGRESQL_USER || 'user';
-const password = process.env.DB_PASSWORD || process.env.POSTGRESQL_PASSWORD || 'password';
+const user = process.env.DB_USERNAME || process.env.POSTGRESQL_USER || 'luke';
+const password = process.env.DB_PASSWORD || process.env.POSTGRESQL_PASSWORD || 'secret';
 const databaseName = process.env.POSTGRESQL_DATABASE || 'my_data';
 const connectionString = `postgresql://${user}:${password}@${serviceHost}:5432/${databaseName}`;
 
 const pool = new Pool({
   connectionString
 });
 
-let didInitHappen = false;
+async function didInitHappen () {
+  const query = 'select * from products';
+
+  try {
+    await pool.query(query);
+    console.log('Database Already Created');
+    return true;
+  } catch (err) {
+    return false;
+  }
+}
 
 // -- Create the products table if not present
 const initScript = `CREATE TABLE IF NOT EXISTS products (
@@ -28,17 +38,19 @@ INSERT INTO products (name, stock) values ('Pear', 10);`;
 
 async function query (text, parameters) {
   // Check that we have initialized the DB on each Query request
-  if (!didInitHappen) {
+  const initHappened = await didInitHappen();
+  if (!initHappened) {
     await init();
   }
 
   return pool.query(text, parameters);
 }
 
-function init () {
-  return pool.query(initScript).then(() => {
-    didInitHappen = true;
-  });
+async function init () {
+  const initHappened = await didInitHappen();
+  if (!initHappened) {
+    return pool.query(initScript);
+  }
 }
 
 module.exports = {