This repository has been archived by the owner on Oct 7, 2020. It is now read-only.
wasi: put wasi behind a flag #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
danbev
approved these changes
Sep 26, 2019
There was a problem hiding this comment.
Just noticed that there is one test failure, test-process-env-allowed-flags-are-documented.js. The following patch allowed this to pass for me:
diff --git a/doc/api/cli.md b/doc/api/cli.md
index 6d09b85842..27f5162079 100644
--- a/doc/api/cli.md
+++ b/doc/api/cli.md
@@ -198,6 +198,13 @@ added: v12.3.0
Enable experimental WebAssembly module support.
+### `--experimental-wasi`
+<!-- YAML
+added: REPLACEME
+-->
+
+Enable experimental WebAssembly System Interface (Wasi) support.
+
### `--force-fips`
<!-- YAML
added: v6.0.0
@@ -986,6 +993,7 @@ Node.js options that are allowed are:
* `--experimental-repl-await`
* `--experimental-report`
* `--experimental-vm-modules`
+* `--experimental-wasi`
* `--experimental-wasm-modules`
* `--force-context-aware`
* `--force-fips`
This commit puts the WASI implementation behind a --experimental-wasi CLI flag, and prints an experimental warning on first use of WASI. It also includes some misc cleanup.
|
Good catch @danbev. Thanks! I've incorporated your changes and ran the full test suite locally. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit puts the WASI implementation behind an
--experimental-wasiCLI flag, and prints an experimental warning on first use of WASI. It also includes some misc cleanup.