Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix other places with unsigned long overflow #162

Merged
merged 1 commit into from
Mar 20, 2021

Conversation

vshymanskyy
Copy link
Contributor

Similar to #161 , but fixes other places.
With this, finally have all Wasm3 tests passing: https://github.com/wasm3/wasm3/actions/runs/671457352
@cjihrig sorry for bothering ;)

Copy link
Collaborator

@cjihrig cjihrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for bothering ;)

No bother 😄

@cjihrig cjihrig merged commit adda155 into nodejs:master Mar 20, 2021
cjihrig added a commit that referenced this pull request Nov 13, 2021
Notable changes:

- The project is now hosted under the nodejs GitHub org. (4911b55)
- Several overflows have been fixed. (#161) (#162)
- The libuv dependency has been updated to v1.42.0. (#167)
@cjihrig cjihrig mentioned this pull request Nov 13, 2021
cjihrig added a commit that referenced this pull request Nov 17, 2021
Notable changes:

- The project is now hosted under the nodejs GitHub org. (4911b55)
- Several overflows have been fixed. (#161) (#162)
- The libuv dependency has been updated to v1.42.0. (#167)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants