Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix dns interceptor flakiness #3902

Merged
merged 1 commit into from
Nov 29, 2024

Conversation

luddd3
Copy link
Contributor

@luddd3 luddd3 commented Nov 29, 2024

This relates to...

Fixes #3898

Rationale

Use fake timers to reduce test flakiness

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@ronag ronag merged commit 4b85f4e into nodejs:main Nov 29, 2024
30 of 31 checks passed
@luddd3 luddd3 deleted the test-dns-interceptor-flaky branch November 29, 2024 21:42
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
This was referenced Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky test at test/interceptors/dns.js
3 participants