Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: port retry to new hooks #3883

Merged
merged 7 commits into from
Nov 27, 2024
Merged

fix: port retry to new hooks #3883

merged 7 commits into from
Nov 27, 2024

Conversation

ronag
Copy link
Member

@ronag ronag commented Nov 26, 2024

This relates to...

Rationale

Changes

Features

Bug Fixes

Breaking Changes and Deprecations

Status

@ronag ronag force-pushed the new-hooks-retry branch 3 times, most recently from bc3f9d2 to c0e7bca Compare November 26, 2024 11:04
@ronag ronag marked this pull request as ready for review November 26, 2024 11:04
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag force-pushed the new-hooks-retry branch 3 times, most recently from db0410d to f258bd5 Compare November 26, 2024 15:33
Copy link
Member

@metcoder95 metcoder95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but think the tests are not happy

@ronag ronag force-pushed the new-hooks-retry branch 6 times, most recently from 39a8c81 to 32052ab Compare November 27, 2024 11:21
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ronag ronag merged commit d006e90 into main Nov 27, 2024
34 of 37 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants