feat: add support for Timeout and Trailers #3854
Open
+141
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
metcoder95
commented
Nov 20, 2024
| @@ -278,6 +283,7 @@ function shouldSendContentLength (method) { | |||
| } | |||
|
|
|||
| function writeH2 (client, request) { | |||
| const requestTimeout = request.bodyTimeout ?? client[kBodyTimeout] | |||
There was a problem hiding this comment.
I was quite unsure if using the bodyTimeout for this, and adding a new one. But given the nature of the timeout, using the body's one should be enough.
7 tasks
mcollina
reviewed
Nov 20, 2024
| @@ -375,6 +381,7 @@ function writeH2 (client, request) { | |||
| session[kOpenStreams] -= 1 | |||
| if (session[kOpenStreams] === 0) session.unref() | |||
| }) | |||
| stream.setTimeout(requestTimeout) | |||
There was a problem hiding this comment.
I would not call this if there isn't a requestTimeout.
There was a problem hiding this comment.
Do you mean that if no bodyTimeout passed at a request level, we just ignore it, discarding the one set for the client itself? Or do you have something else in mind?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to...
Rationale
Changes
Features
Bug Fixes
Breaking Changes and Deprecations
Status