Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport v6.x] fix: refactor fast timers, fix UND_ERR_CONNECT_TIMEOUT on event loop blocking #3673

Merged
merged 1 commit into from
Oct 4, 2024
Merged

[Backport v6.x] fix: refactor fast timers, fix UND_ERR_CONNECT_TIMEOUT on event loop blocking #3673

merged 1 commit into from
Oct 4, 2024
+714 −160

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Oct 3, 2024

Backport 8a09d77 from #3495.

@Uzlopak @github-actions
fix: refactor fast timers, fix UND_ERR_CONNECT_TIMEOUT on event loop …
43a2e1b 
…blocking (#3495)

* fix: refactor fast timers, fix UND_ERR_CONNECT_TIMEOUT on event loop blocking

* also test native timers

* improve the commentary of fasttimers

* revert changes in client-h1.js

* make fasttimers independent from performance.now

* less flaky?

(cherry picked from commit 8a09d77)
@Uzlopak Uzlopak closed this Oct 3, 2024
@Uzlopak Uzlopak reopened this Oct 3, 2024
mcollina
mcollina approved these changes Oct 4, 2024
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 6764626 into v6.x Oct 4, 2024
28 checks passed
@mcollina mcollina deleted the backport-3495-to-v6.x branch October 4, 2024 07:17
@leonardoadame leonardoadame mentioned this pull request Oct 31, 2024
Open
@dolevmiz1 dolevmiz1 mentioned this pull request Nov 2, 2024
Open
@thoukydides thoukydides mentioned this pull request Nov 4, 2024
Closed
@leonardoadame leonardoadame mentioned this pull request Nov 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcollina @Uzlopak