Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: improve jsdoc and minor changes in EventSource #3480

Merged
merged 1 commit into from
Aug 19, 2024
Merged

chore: improve jsdoc and minor changes in EventSource #3480

merged 1 commit into from
Aug 19, 2024

Conversation

Uzlopak
Copy link
Contributor

@Uzlopak Uzlopak commented Aug 16, 2024

reduces some codesmells

@Uzlopak Uzlopak requested a review from KhafraDev August 16, 2024 20:53
mertcanaltin
mertcanaltin approved these changes Aug 19, 2024
View reviewed changes
Copy link
Member

@mertcanaltin mertcanaltin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Uzlopak Uzlopak merged commit 5af9963 into nodejs:main Aug 19, 2024
32 checks passed
@github-actions github-actions bot mentioned this pull request Dec 3, 2024
Merged
This was referenced Dec 16, 2024
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mertcanaltin mertcanaltin mertcanaltin approved these changes

@metcoder95 metcoder95 metcoder95 approved these changes

@KhafraDev KhafraDev Awaiting requested review from KhafraDev

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Uzlopak @metcoder95 @mertcanaltin