fix user-agent detection #2340
Closed
fix user-agent detection #2340
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #2340 +/- ##
==========================================
+ Coverage 85.54% 92.28% +6.73%
==========================================
Files 76 41 -35
Lines 6858 3253 -3605
==========================================
- Hits 5867 3002 -2865
+ Misses 991 251 -740
☔ View full report in Codecov by Sentry. |
|
esbuild will rename it to something else when rebundled, this doesn't work |
| httpRequest.headersList.append('user-agent', __filename.endsWith('index.js') ? 'undici' : 'node') | ||
| // __commonJS is injected by esbuild when bundled. The esbuild bundle is used in node core. | ||
| // Therefore if we're running the esbuild bundle, we're likely in node core. | ||
| httpRequest.headersList.append('user-agent', typeof __commonJS !== 'function' ? 'undici' : 'node') |
There was a problem hiding this comment.
not a fan of relying on an unspecified global. Someone could decide to set this themselves and undici would break itself.
There was a problem hiding this comment.
fwiw it's also possible to set __filename
There was a problem hiding this comment.
true but there is at least an assumption/definition for __filename. If someone decides to mess with that - it's on them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #2310 (comment)
I confirmed that this fixes the issue in node core.