bump engines to node >= 16

[ronag]

Node 14 is EOL and no longer supported.

[KhafraDev]

We can finally use optional chaining and nullish coalescing 👀

[codecov-commenter]

Codecov Report

Patch coverage has no change and project coverage change: -0.29 ⚠️

Comparison is base (9d30456) 85.86% compared to head (f30fd54) 85.58%.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2119      +/-   ##
==========================================
- Coverage   85.86%   85.58%   -0.29%     
==========================================
  Files          76       75       -1     
  Lines        6610     6609       -1     
==========================================
- Hits         5676     5656      -20     
- Misses        934      953      +19     

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

[mcollina]

note that this is a server-major change.

[mcollina]

this is a semver major change. Given v16 is out of support at the end of September, I think we could just “jump” to v18 minimum.

[KhafraDev]

I think we should wait to drop v16, otherwise there will be people on a supported version of node that can't use undici. I thought about dropping v16 support too but decided against it until it's EOL.

edit: dropping v16 would be very helpful for fetch as well since there's a few issues in v16 that break fetch in very specific ways.

[Ethan-Arrowood]

Yeah, please keep 16 support for now. I see little harm in doing another Undici major release when 16 hits EOL.

At Vercel we use Undici and fetch from core heavily. We can't drop Node 14 or 16 support as quickly and so will have to pin these older versions of Undici until we can properly drop support for 14 and 16 ourselves.

[mcollina]

I would recommend we revert this change then. Let's drop v14 and v16 when v16 enters EOL.