-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fetch): improve Headers and Request type-compatibility #1947
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -68,7 +68,7 @@ export declare class Headers implements SpecIterable<[string, string]> { | |
readonly keys: () => SpecIterableIterator<string> | ||
readonly values: () => SpecIterableIterator<string> | ||
readonly entries: () => SpecIterableIterator<[string, string]> | ||
readonly [Symbol.iterator]: () => SpecIterator<[string, string]> | ||
readonly [Symbol.iterator]: () => SpecIterableIterator<[string, string]> | ||
} | ||
|
||
export type RequestCache = | ||
|
@@ -146,7 +146,8 @@ export declare class Request implements BodyMixin { | |
readonly method: string | ||
readonly mode: RequestMode | ||
readonly redirect: RequestRedirect | ||
readonly referrerPolicy: string | ||
readonly referrer: string | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding the missing |
||
readonly referrerPolicy: ReferrerPolicy | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Also narrowing down the referrer policy as we already have the |
||
readonly url: string | ||
|
||
readonly keepalive: boolean | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears that the iterator symbol on
Headers
must be iterable.