Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

types: remove old signature #1658

Merged
merged 1 commit into from
Sep 20, 2022
Merged

types: remove old signature #1658

merged 1 commit into from
Sep 20, 2022

Conversation

KhafraDev
Copy link
Member

The default export was removed in 9c04cfa

@codecov-commenter
Copy link

codecov-commenter commented Sep 19, 2022

Codecov Report

Base: 94.87% // Head: 94.89% // Increases project coverage by +0.02% 🎉

Coverage data is based on head (9c2f8d9) compared to base (674875a).
Patch has no changes to coverable lines.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1658      +/-   ##
==========================================
+ Coverage   94.87%   94.89%   +0.02%     
==========================================
  Files          53       53              
  Lines        4803     4803              
==========================================
+ Hits         4557     4558       +1     
+ Misses        246      245       -1     
Impacted Files Coverage Δ
lib/fetch/file.js 92.94% <0.00%> (+1.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit e5e5b97 into nodejs:main Sep 20, 2022
@KhafraDev KhafraDev deleted the default-type branch September 20, 2022 12:45
metcoder95 pushed a commit to metcoder95/undici that referenced this pull request Dec 26, 2022
crysmags pushed a commit to crysmags/undici that referenced this pull request Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants