-
Notifications
You must be signed in to change notification settings - Fork 540
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(fetch): replace instanceof FormData
check
#1457
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1457 +/- ##
==========================================
+ Coverage 94.42% 94.44% +0.01%
==========================================
Files 49 49
Lines 4271 4285 +14
==========================================
+ Hits 4033 4047 +14
Misses 238 238
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't have an opinion on this. +/- 0. @mcollina @KhafraDev @Ethan-Arrowood @targos thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add a test?
I'm not sure what sort of test I could add that tests this edge case. Also |
Added a simple test, let me know if it's sufficient @mcollina: https://github.com/nodejs/undici/compare/213706c71daa48705cf5a4da096ac0f23c8cbefb..2e5814b077e2695eadcc7b9b87e8e8899031e27c How frequently do you publish new versions btw? |
Once we have some time. At least once a month, ideally every two weeks. |
See #1451 (comment)
I've tested this using
esbuild
with--minify
andutil.isFormData
still works on a minifiedFormData
class