fetch: avoid async iteration when request.body is null #1303
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1303 +/- ##
=======================================
Coverage 94.16% 94.16%
=======================================
Files 45 45
Lines 4112 4114 +2
=======================================
+ Hits 3872 3874 +2
Misses 240 240
Continue to review full report at Codecov.
|
mcollina
requested changes
Mar 28, 2022
mcollina
approved these changes
Mar 28, 2022
|
lgtm |
ronag
approved these changes
Mar 28, 2022
There was a problem hiding this comment.
@RafaelGSS I slightly modified your PR. Hope you don't mind. LGTM. If you approve we can merge.
RafaelGSS
commented
Mar 28, 2022
KhafraDev
pushed a commit
to KhafraDev/undici
that referenced
this pull request
Jun 23, 2022
* fetch: avoid iteration when request.body is null * slightly simplify Co-authored-by: Robert Nagy <[email protected]>
metcoder95
pushed a commit
to metcoder95/undici
that referenced
this pull request
Dec 26, 2022
* fetch: avoid iteration when request.body is null * slightly simplify Co-authored-by: Robert Nagy <[email protected]>
crysmags
pushed a commit
to crysmags/undici
that referenced
this pull request
Feb 27, 2024
* fetch: avoid iteration when request.body is null * slightly simplify Co-authored-by: Robert Nagy <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It avoids treating
request.bodyas an async iterator when it's null.In my local tests, it increases the performance by almost 10%.