Revert "fix: post request signal (#3354)"

This reverts commit a5eac88.
nodejs · Jun 22, 2024 · 1e35201 · 1e35201
1 parent a5eac88
commit 1e35201
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 28 deletions.
diff --git a/lib/api/api-request.js b/lib/api/api-request.js
@@ -154,11 +154,6 @@ class RequestHandler extends AsyncResource {
   }
 
   onComplete (trailers) {
-    if (this.removeAbortListener) {
-      this.removeAbortListener()
-      this.removeAbortListener = null
-    }
-
     util.parseHeaders(trailers, this.trailers)
     this.res.push(null)
   }

diff --git a/test/request-signal.js b/test/request-signal.js
@@ -36,11 +36,9 @@ test('post abort signal', async (t) => {
 
   server.listen(0, async () => {
     const ac = new AbortController()
-    const uresPromise = request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal })
+    const ures = await request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal })
     ac.abort()
-
     try {
-      const ures = await uresPromise
       /* eslint-disable-next-line no-unused-vars */
       for await (const chunk of ures.body) {
         // Do nothing...
@@ -63,11 +61,9 @@ test('post abort signal w/ reason', async (t) => {
   server.listen(0, async () => {
     const ac = new AbortController()
     const _err = new Error()
-    const uresPromise = request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal })
+    const ures = await request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal })
     ac.abort(_err)
-
     try {
-      const ures = await uresPromise
       /* eslint-disable-next-line no-unused-vars */
       for await (const chunk of ures.body) {
         // Do nothing...
@@ -78,20 +74,3 @@ test('post abort signal w/ reason', async (t) => {
   })
   await t.completed
 })
-
-test('post abort signal after request completed', async (t) => {
-  t = tspl(t, { plan: 1 })
-
-  const server = createServer((req, res) => {
-    res.end('asd')
-  })
-  after(() => server.close())
-
-  server.listen(0, async () => {
-    const ac = new AbortController()
-    const ures = await request(`http://0.0.0.0:${server.address().port}`, { signal: ac.signal })
-    ac.abort()
-    t.equal(await ures.body.text(), 'asd')
-  })
-  await t.completed
-})