This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: stringify NGTCP2_ALPN_H3 constant #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the constant NGTCP2_ALPN_H3 is not being set correctly: AF_INET: 2, AF_INET6: 30, '\x05h3-24': '\x05h3-24' This commit stringifies the constant name so that this becomes: AF_INET: 2, AF_INET6: 30, NGTCP2_ALPN_H3: '\x05h3-24' This was causing the test-quic-binding.js test to fail.
jasnell
approved these changes
Jan 15, 2020
jasnell
pushed a commit
that referenced
this pull request
Jan 15, 2020
Currently, the constant NGTCP2_ALPN_H3 is not being set correctly: AF_INET: 2, AF_INET6: 30, '\x05h3-24': '\x05h3-24' This commit stringifies the constant name so that this becomes: AF_INET: 2, AF_INET6: 30, NGTCP2_ALPN_H3: '\x05h3-24' This was causing the test-quic-binding.js test to fail. PR-URL: #285 Reviewed-By: James M Snell <[email protected]>
|
Landed |
jasnell
pushed a commit
to jasnell/quic
that referenced
this pull request
Feb 3, 2020
Currently, the constant NGTCP2_ALPN_H3 is not being set correctly: AF_INET: 2, AF_INET6: 30, '\x05h3-24': '\x05h3-24' This commit stringifies the constant name so that this becomes: AF_INET: 2, AF_INET6: 30, NGTCP2_ALPN_H3: '\x05h3-24' This was causing the test-quic-binding.js test to fail. PR-URL: nodejs#285 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the constant
NGTCP2_ALPN_H3is not being set correctly:This commit stringifies the constant name so that this becomes:
This was causing the
test-quic-binding.jstest to fail.Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes