This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
quic: fix linting and tests #179
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Once again, linter and tests have been failing because of recent changes. :)
addaleax
commented
Oct 16, 2019
| @@ -1,11 +1,11 @@ | |||
| #include "node.h" | |||
| #include "debug_utils.h" | |||
| #include "node_http_common.h" | |||
| #include "node_mem-inl.h" | |||
There was a problem hiding this comment.
(This is to match #178)
|
ah... I keep forgetting to lint the c bits on linux instead of windows. |
jasnell
approved these changes
Oct 16, 2019
trivikr
approved these changes
Oct 16, 2019
jasnell
pushed a commit
that referenced
this pull request
Oct 17, 2019
Once again, linter and tests have been failing because of recent changes. :) PR-URL: #179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
|
landed! |
addaleax
added a commit
that referenced
this pull request
Dec 11, 2019
Once again, linter and tests have been failing because of recent changes. :) PR-URL: #179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Once again, linter and tests have been failing because of recent changes. :) PR-URL: nodejs#179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
Once again, linter and tests have been failing because of recent changes. :) PR-URL: nodejs#179 Reviewed-By: James M Snell <[email protected]> Reviewed-By: Trivikram Kamat <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once again, linter and tests have been failing because of recent
changes. :)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes