This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
test: add tests for quic idleTimeout
#160
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO.
jasnell
approved these changes
Oct 9, 2019
jasnell
pushed a commit
that referenced
this pull request
Oct 9, 2019
It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO. PR-URL: #160 Reviewed-By: James M Snell <[email protected]>
|
Landed |
|
This test is timing out 100 % of the time for me. |
addaleax
pushed a commit
that referenced
this pull request
Dec 11, 2019
It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO. PR-URL: #160 Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO. PR-URL: nodejs#160 Reviewed-By: James M Snell <[email protected]>
juanarbol
pushed a commit
to juanarbol/quic
that referenced
this pull request
Dec 17, 2019
It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO. PR-URL: nodejs#160 Reviewed-By: James M Snell <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It would be better to add a test to ensure that the timeout is greater than the triple PTO if we can get the PTO.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes(https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)