This repository has been archived by the owner on Aug 11, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 49
C++-side refactor #126
Closed
C++-side refactor #126
Commits on Sep 20, 2019
-
quic: remove user_data from quic buffer callback
Using `std::function` and an opaque pointer are pretty much antithetical. This commit chooses the more C++-y variant, i.e. `std::function`.
Configuration menu - View commit details
-
Copy full SHA for 75ea63b - Browse repository at this point
Copy the full SHA 75ea63bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 762d03f - Browse repository at this point
Copy the full SHA 762d03fView commit details -
quic: cleanup node_quic_buffer.h
Prefer inline functions over macros, use explicit nullptr checks, do not mark functions with implicit inline linkage as inline, re-use code where possible, etc.
Configuration menu - View commit details
-
Copy full SHA for 4a11d59 - Browse repository at this point
Copy the full SHA 4a11d59View commit details
Commits on Sep 21, 2019
-
Move methods that do not need to be inline into their own file, replace `std::function` with a template variant for performance, remove `inline` for functions with implicit inline linkage.
Configuration menu - View commit details
-
Copy full SHA for 1ccfbd2 - Browse repository at this point
Copy the full SHA 1ccfbd2View commit details -
quic: remove opaque pointer from Timer callback
Use the more C++-y `std::function` approach which renders opaque pointers unnecessary.
Configuration menu - View commit details
-
Copy full SHA for 650ea1f - Browse repository at this point
Copy the full SHA 650ea1fView commit details -
quic: cleanup QuicSession code
- Do not create new `v8::Function` objects, both for performance and because it is unclear whether that leaks memory (Node.js issue 28988). - Do not put functions into the inline header that do not need to be there or that do not make sense as inline functions (in particular, callbacks that are provided to C libraries can not be realized as inline functions by the compiler). - Remove implicit/redundant `inline` qualifiers and add appropriate `const` qualifiers. - Remove unnecessary `this->` prefixes. - Return early for JS failures rather than accumulating them. - Minor stylistic changes.
Configuration menu - View commit details
-
Copy full SHA for bdd45bd - Browse repository at this point
Copy the full SHA bdd45bdView commit details -
src: refactor memory tracker implementation
Use a template class instead of virtual methods to allow inlining the subclass methods, as well as other minor cleanups.
Configuration menu - View commit details
-
Copy full SHA for e334d94 - Browse repository at this point
Copy the full SHA e334d94View commit details -
http2: use shared memory tracking implementation
The extensive testing done on http2 makes it easier to make sure the implementation is correct (and doesn’t diverge unnecessarily).
Configuration menu - View commit details
-
Copy full SHA for 34f46df - Browse repository at this point
Copy the full SHA 34f46dfView commit details -
quic: remove QuicStreamListener
This listener currently had the drawbacks of leaking memory when an error is encountered and was otherwise equivalent to the default listener.
Configuration menu - View commit details
-
Copy full SHA for 5f0ea8e - Browse repository at this point
Copy the full SHA 5f0ea8eView commit details -
quic: more general C++ cleanup
Use default initializers, `const` qualifiers, minor style changes to match more common style in the codebase.
Configuration menu - View commit details
-
Copy full SHA for 96b22fd - Browse repository at this point
Copy the full SHA 96b22fdView commit details
Commits on Sep 23, 2019
-
Configuration menu - View commit details
-
Copy full SHA for c7015ef - Browse repository at this point
Copy the full SHA c7015efView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3f1b93f - Browse repository at this point
Copy the full SHA 3f1b93fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.