fix: OOM abort error while injecting data #45
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RaisinTen
requested review from
dsanders11,
jviotti and
robertgzr
as code owners
Closed
RaisinTen
commented
Sep 28, 2022
|
Can we change the commit message to be more generic? This fixes memory limits in general, not specific to Node.js, so want that to be clear. Also, can we include all of the changes I suggested previously? I think we should set |
After building Postject with -sASSERTIONS enabled, the error looked like this: ``` Aborted(Cannot enlarge memory arrays to size 82239488 bytes (OOM). Either (1) compile with -sINITIAL_MEMORY=X with X higher than the current value 16777216, (2) compile with -sALLOW_MEMORY_GROWTH which allows increasing the size at runtime, or (3) if you want malloc to return NULL (0) instead of this abort, compile with -sABORTING_MALLOC=0) ``` so I followed option 2 in this change. Fixes: #42 Signed-off-by: Darshan Sen <[email protected]>
40000ms is still too for macOS. Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/139/workflows/aee3c215-ddc7-4451-aad5-70bfc58dd8c3/jobs/1051/tests Signed-off-by: Darshan Sen <[email protected]>
50000ms is still too low for macOS. Refs: https://app.circleci.com/pipelines/github/postmanlabs/postject/140/workflows/d653f352-5415-4a83-95b8-c3a52393dc76/jobs/1062/tests Signed-off-by: Darshan Sen <[email protected]>
Resolves a code review comment. Signed-off-by: Darshan Sen <[email protected]>
RaisinTen
force-pushed
the
fix/OOM-abort-error-while-injecting-data-into-Node.js
branch
from
641d7b3
to
285825d
Compare
RaisinTen
changed the title
|
@dsanders11 done, PTAL! |
dsanders11
approved these changes
Sep 30, 2022
dsanders11
deleted the
fix/OOM-abort-error-while-injecting-data-into-Node.js
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After building Postject with
-sASSERTIONSenabled, the error looked like this:so I followed option 2 in this change.
Fixes: #42
Signed-off-by: Darshan Sen [email protected]