-
Notifications
You must be signed in to change notification settings - Fork 6.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(learn): Migrate the legacy guide "Debugging - Getting Started" to the learn section #6265
docs(learn): Migrate the legacy guide "Debugging - Getting Started" to the learn section #6265
Conversation
…the learn section
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job !
Title should be "debugging Node.js". WDYT ?
also ---
(<hr/>
) is it really necessary
Yes, I like your suggested title. I'll work on this |
Changes ready! |
Lighthouse Results
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for your contribution
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM ! Thanks for you first contribution 🎉
Thanks for the review! Excited to contribute more in the future. |
The webpage at the URL referenced by `node --inspect` was retitled when it was recently moved. Update the test to match the new title "Debugging Node.js" (formerly "Debugging Guide"). Refs: nodejs/nodejs.org#6265
The webpage at the URL referenced by `node --inspect` was retitled when it was recently moved. Update the test to match the new title "Debugging Node.js" (formerly "Debugging Guide"). Refs: nodejs/nodejs.org#6265 PR-URL: #51693 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
The webpage at the URL referenced by `node --inspect` was retitled when it was recently moved. Update the test to match the new title "Debugging Node.js" (formerly "Debugging Guide"). Refs: nodejs/nodejs.org#6265 PR-URL: #51693 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
The webpage at the URL referenced by `node --inspect` was retitled when it was recently moved. Update the test to match the new title "Debugging Node.js" (formerly "Debugging Guide"). Refs: nodejs/nodejs.org#6265 PR-URL: #51693 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
The webpage at the URL referenced by `node --inspect` was retitled when it was recently moved. Update the test to match the new title "Debugging Node.js" (formerly "Debugging Guide"). Refs: nodejs/nodejs.org#6265 PR-URL: nodejs#51693 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
The webpage at the URL referenced by `node --inspect` was retitled when it was recently moved. Update the test to match the new title "Debugging Node.js" (formerly "Debugging Guide"). Refs: nodejs/nodejs.org#6265 PR-URL: #51693 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
The webpage at the URL referenced by `node --inspect` was retitled when it was recently moved. Update the test to match the new title "Debugging Node.js" (formerly "Debugging Guide"). Refs: nodejs/nodejs.org#6265 PR-URL: #51693 Reviewed-By: Michaël Zasso <[email protected]> Reviewed-By: Luigi Pinca <[email protected]> Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Description
This PR migrates the legacy guide "Debugging - Getting Started" to the learn section, and also renames the guide to just "Debugging" to avoid redundancy; given that it was inserted inside the getting started subsection in learn.
Validation
Guide was removed from "guides" section:
Guide was added to "learn" section, inside getting started subsection:
Related Issues
Fixes #6219
Check List
npx turbo lint
to ensure the code follows the style guide. And runnpx turbo lint:fix
to fix the style errors if necessary.npx turbo format
to ensure the code follows the style guide.npx turbo test
to check if all tests are passing.