Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(learn): Migrate the legacy guide "Debugging - Getting Started" to the learn section #6265

Merged

Conversation

fercho-dev
Copy link
Contributor

Description

This PR migrates the legacy guide "Debugging - Getting Started" to the learn section, and also renames the guide to just "Debugging" to avoid redundancy; given that it was inserted inside the getting started subsection in learn.

Validation

Guide was removed from "guides" section:
Captura de pantalla 2024-01-23 a la(s) 22 41 42

Guide was added to "learn" section, inside getting started subsection:
Captura de pantalla 2024-01-23 a la(s) 22 42 14

Related Issues

Fixes #6219

Check List

  • I have read the Contributing Guidelines and made commit messages that follow the guideline.
  • I have run npx turbo lint to ensure the code follows the style guide. And run npx turbo lint:fix to fix the style errors if necessary.
  • I have run npx turbo format to ensure the code follows the style guide.
  • I have run npx turbo test to check if all tests are passing.
  • I've covered new added functionality with unit tests if necessary.

@fercho-dev fercho-dev requested a review from a team as a code owner January 24, 2024 05:00
Copy link

vercel bot commented Jan 24, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 24, 2024 3:23pm

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job !

Title should be "debugging Node.js". WDYT ?
also --- (<hr/>) is it really necessary

pages/en/learn/getting-started/debugging.md Outdated Show resolved Hide resolved
pages/en/learn/getting-started/debugging.md Outdated Show resolved Hide resolved
i18n/locales/en.json Outdated Show resolved Hide resolved
@fercho-dev
Copy link
Contributor Author

Great job !

Title should be "debugging Node.js". WDYT ? also --- (<hr/>) is it really necessary

Yes, I like your suggested title.
and for the ---, I dont think they're really necessary. I can remove them.

I'll work on this

@fercho-dev
Copy link
Contributor Author

Changes ready!

@mikeesto mikeesto added the github_actions:pull-request Trigger Pull Request Checks label Jan 26, 2024
@github-actions github-actions bot removed the github_actions:pull-request Trigger Pull Request Checks label Jan 26, 2024
Copy link

github-actions bot commented Jan 26, 2024

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 100 🟢 100 🟢 92 🟢 92 🔗
/en/about 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/about/previous-releases 🟢 100 🟢 96 🟢 92 🟢 92 🔗
/en/download 🟢 100 🟢 97 🟢 92 🟢 92 🔗
/en/blog 🟢 100 🟢 97 🟢 92 🟢 92 🔗

Copy link

Unit Test Coverage Report

Lines Statements Branches Functions
Coverage: 90%
86.49% (397/459) 77.33% (116/150) 77.77% (70/90)

Unit Test Report

Tests Skipped Failures Errors Time
72 0 💤 0 ❌ 0 🔥 4.17s ⏱️

Copy link
Member

@mikeesto mikeesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for your contribution

Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! Thanks for you first contribution 🎉

@fercho-dev
Copy link
Contributor Author

LGTM, thanks for your contribution

LGTM ! Thanks for you first contribution 🎉

Thanks for the review! Excited to contribute more in the future.

@bmuenzenmeyer bmuenzenmeyer added this pull request to the merge queue Feb 4, 2024
Merged via the queue into nodejs:main with commit a059d56 Feb 4, 2024
16 checks passed
richardlau added a commit to richardlau/nodejs.org that referenced this pull request Feb 6, 2024
github-merge-queue bot pushed a commit that referenced this pull request Feb 6, 2024
richardlau added a commit to richardlau/node-1 that referenced this pull request Feb 7, 2024
The webpage at the URL referenced by `node --inspect` was retitled when
it was recently moved.

Update the test to match the new title "Debugging Node.js" (formerly
"Debugging Guide").

Refs: nodejs/nodejs.org#6265
nodejs-github-bot pushed a commit to nodejs/node that referenced this pull request Feb 16, 2024
The webpage at the URL referenced by `node --inspect` was retitled when
it was recently moved.

Update the test to match the new title "Debugging Node.js" (formerly
"Debugging Guide").

Refs: nodejs/nodejs.org#6265
PR-URL: #51693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
targos pushed a commit to nodejs/node that referenced this pull request Feb 19, 2024
The webpage at the URL referenced by `node --inspect` was retitled when
it was recently moved.

Update the test to match the new title "Debugging Node.js" (formerly
"Debugging Guide").

Refs: nodejs/nodejs.org#6265
PR-URL: #51693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
richardlau added a commit to nodejs/node that referenced this pull request Mar 19, 2024
The webpage at the URL referenced by `node --inspect` was retitled when
it was recently moved.

Update the test to match the new title "Debugging Node.js" (formerly
"Debugging Guide").

Refs: nodejs/nodejs.org#6265
PR-URL: #51693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
rdw-msft pushed a commit to rdw-msft/node that referenced this pull request Mar 20, 2024
The webpage at the URL referenced by `node --inspect` was retitled when
it was recently moved.

Update the test to match the new title "Debugging Node.js" (formerly
"Debugging Guide").

Refs: nodejs/nodejs.org#6265
PR-URL: nodejs#51693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
richardlau added a commit to nodejs/node that referenced this pull request Mar 25, 2024
The webpage at the URL referenced by `node --inspect` was retitled when
it was recently moved.

Update the test to match the new title "Debugging Node.js" (formerly
"Debugging Guide").

Refs: nodejs/nodejs.org#6265
PR-URL: #51693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
richardlau added a commit to nodejs/node that referenced this pull request Mar 25, 2024
The webpage at the URL referenced by `node --inspect` was retitled when
it was recently moved.

Update the test to match the new title "Debugging Node.js" (formerly
"Debugging Guide").

Refs: nodejs/nodejs.org#6265
PR-URL: #51693
Reviewed-By: Michaël Zasso <[email protected]>
Reviewed-By: Luigi Pinca <[email protected]>
Reviewed-By: Mohammed Keyvanzadeh <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate the legacy guide "Debugging - Getting Started" to the learn section
5 participants