meta: refactor data generation to server-side only

[ovflowd]

Description

This PR completely removes the data generation (blogData, nodeReleaseData) from the client-side and completely removes the generation to be done as a pre-build/pre-serve script.

This allows us to generate the data on-demand within Next.js itself and enable HMR of the data if needed.

This removes the need of stashing, unstaging the pesky files from public/ on every commit and checkout.

This completely removes these JSON files (including site navigation, site config, etc) from the client-side and make them a server-side/static-only data. Which completely removes them from the client-side bundle and drastically reduces the bundle size.

Validation

All pages should be working as expected.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Nov 23, 2023 7:37pm

[github-actions]

Lighthouse Results

URL	Performance	Accessibility	Best Practices	SEO	Report
/en	🟢 100	🟢 97	🟢 92	🟢 92	🔗
/en/about	🟢 100	🟢 95	🟠 83	🟢 92	🔗
/en/about/previous-releases	🟢 99	🟢 93	🟢 92	🟢 92	🔗
/en/download	🟢 100	🟢 95	🟢 92	🟢 92	🔗
/en/blog	🟢 99	🟢 95	🟢 92	🟢 92	🔗

[github-actions]

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	90.59% (366/404)	77.77% (91/117)	89.04% (65/73)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
71	0 💤	0 ❌	0 🔥	5.017s ⏱️

[AugustinMauroy]

great change. And why not using route handler to generate data. And use fetch api to consume data ?

[ovflowd]

great change. And why not using route handler to generate data. And use fetch api to consume data ?

Because, not sure you forgot, we need to support static exports.

[ovflowd]

Also why the hell would we want to use an API endpoint for static data.

[AugustinMauroy]

Because, not sure you forgot, we need to support static exports.

yes with static export it's doesn't work

Also why the hell would we want to use an API endpoint for static data.

To reduce custom part and use such as possible nextjs api.

[ovflowd]

To reduce custom part and use such as possible nextjs API.

Sorry, but this doesn't make much sense. This static data needs to be available directly at component level. Using an API means this data would be moved to "getStaticProps" or something similar or require swr or fetch within the components, which for server components works, but still unnecessary fetching (even if cached) on the server-side.

It is a path, and would work, but I doubt it is something that makes sense for something that is just config data.

For the blog post data and release data, I could explore this path, so that we don't call this endpoint on every bootstrap of ISR, but still, something that I need to honestly check what would be the best appropriate path here.

[ovflowd]

To reduce custom part and use such as possible nextjs API.

Sorry, but this doesn't make much sense. This static data needs to be available directly at component level. Using an API means this data would be moved to "getStaticProps" or something similar or require swr or fetch within the components, which for server components works, but still unnecessary fetching (even if cached) on the server-side.

It is a path, and would work, but I doubt it is something that makes sense for something that is just config data.

For the blog post data and release data, I could explore this path, so that we don't call this endpoint on every bootstrap of ISR, but still, something that I need to honestly check what would be the best appropriate path here.

This is proving complex. Ill meditate about this later.

[AugustinMauroy]

Don't worry, what you've updated is great.

[ovflowd]

Don't worry, what you've updated is great.

Done, I think I was able to stretch some brain cells to their limit.

[ovflowd]

cc @nodejs/web-infra would love some reviews of people that know their stuff around web

[AugustinMauroy]

why route handler is under [local] ? it's not possible to put on app/api/... ?
the rest to support static export is superbly done

[ovflowd]

why route handler is under [local] ? it's not possible to put on app/api/... ?

the rest to support static export is superbly done

No. You also forget that nodejs.org/api is a reserved word. It goes to our api docs.

[AugustinMauroy]

No. You also forget that nodejs.org/api is a reserved word. It goes to our api docs.

true but my real question is why put route handler under I18n

[ovflowd]

No. You also forget that nodejs.org/api is a reserved word. It goes to our api docs.

true but my real question is why put route handler under I18n

Everything in our website goes under a /language/ top level route. To prevent the future where some cloudflare settings could block us from using more than /[locale]/ it just made sense.

Also if in the future we translate any of these, they would already be in the right place 😉

[bmuenzenmeyer]

my initial review - I'd still like to pull it down locally and run it on Windows

[canerakdas]

Great update 🎉 I think this is an update that will make the process more understandable for contributors/newcomers. I left my review notes

[bmuenzenmeyer]

aside from the comments already mentioned - i wanted to say this looks all good on Windows