meta: updated repo structure #5642

ovflowd · 2023-08-15T09:47:51Z

This PR updates relevant sections of the README, CONTRIBUTING.md and COLLABORATOR_GUIDE.md with updated guides, references and technologies.

cc @nodejs/website

Signed-off-by: Claudio Wunder <[email protected]>

vercel · 2023-08-15T09:47:54Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
nodejs-org	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Aug 16, 2023 8:53am

Signed-off-by: Claudio Wunder <[email protected]>

github-actions · 2023-08-15T09:53:26Z

Unit Test Coverage Report

Lines	Statements	Branches	Functions
	92.21% (367/398)	79% (79/100)	88.09% (74/84)

Unit Test Report

Tests	Skipped	Failures	Errors	Time
45	0 💤	0 ❌	0 🔥	12.188s ⏱️

github-actions · 2023-08-15T09:56:11Z

📦 Next.js Bundle Analysis for nodejs.org

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd · 2023-08-15T10:51:54Z

cc @nodejs/website as we need a full review here! (As this PR updates the Contributing Guidelines)

mikeesto

LGTM, just made a couple of small suggestions

COLLABORATOR_GUIDE.md

CONTRIBUTING.md

Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Brian Muenzenmeyer <[email protected]> Signed-off-by: Claudio Wunder <[email protected]>

COLLABORATOR_GUIDE.md

CONTRIBUTING.md

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd · 2023-08-16T08:52:08Z

@bmuenzenmeyer I've addressed all comments!

bmuenzenmeyer · 2023-08-16T11:38:35Z

@ovflowd I unresolved some comments. I am wondering if you intended to stage more changes? there are suggestions made by you that are not committed.

ovflowd · 2023-08-16T11:40:14Z

@bmuenzenmeyer can you double check you're not checking an old version of the diff? Everything is correct over here ;)

bmuenzenmeyer · 2023-08-16T11:42:32Z

@bmuenzenmeyer can you double check you're not checking an old version of the diff? Everything is correct over here ;)

a refresh fixed it 😅

ovflowd · 2023-08-16T11:43:10Z

@bmuenzenmeyer can you double check you're not checking an old version of the diff? Everything is correct over here ;)

a refresh fixed it 😅

I was kinda getting confused lol

meta: updated repo structure

00424c6

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd requested a review from a team as a code owner August 15, 2023 09:47

ovflowd had a problem deploying to Storybook August 15, 2023 09:47 — with GitHub Actions Failure

vercel bot deployed to Preview August 15, 2023 09:48 View deployment

ovflowd added 2 commits August 15, 2023 11:50

meta: removed from the readme

f65732e

Signed-off-by: Claudio Wunder <[email protected]>

meta: moved to the collab guide

9247e6c

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd had a problem deploying to Storybook August 15, 2023 09:50 — with GitHub Actions Failure

ovflowd deployed to Storybook August 15, 2023 09:50 — with GitHub Actions View deployment

vercel bot deployed to Preview August 15, 2023 09:52 View deployment

meta: updated contributing guidelines

fc6affc

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd had a problem deploying to Storybook August 15, 2023 10:01 — with GitHub Actions Failure

vercel bot deployed to Preview August 15, 2023 10:02 View deployment

meta: updated collaborator guide

47ca499

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd had a problem deploying to Storybook August 15, 2023 10:14 — with GitHub Actions Failure

vercel bot deployed to Preview August 15, 2023 10:15 View deployment

fix: fix file formatting

489ea42

ovflowd deployed to Storybook August 15, 2023 10:20 — with GitHub Actions View deployment

vercel bot deployed to Preview August 15, 2023 10:21 View deployment

meta: other minor updates

1f21c18

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd had a problem deploying to Storybook August 15, 2023 10:23 — with GitHub Actions Failure

vercel bot deployed to Preview August 15, 2023 10:24 View deployment

meta: fixed formatting and updated content

00460e7

ovflowd deployed to Storybook August 15, 2023 10:28 — with GitHub Actions View deployment

vercel bot deployed to Preview August 15, 2023 10:29 View deployment

Merge branch 'main' into meta-updated-repo-structure

e54fc37

ovflowd deployed to Storybook August 15, 2023 10:45 — with GitHub Actions View deployment

vercel bot deployed to Preview August 15, 2023 10:46 View deployment

mikeesto approved these changes Aug 16, 2023

View reviewed changes

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

bmuenzenmeyer reviewed Aug 16, 2023

View reviewed changes

Apply suggestions from code review

7a89cac

Co-authored-by: Michael Esteban <[email protected]> Co-authored-by: Brian Muenzenmeyer <[email protected]> Signed-off-by: Claudio Wunder <[email protected]>

ovflowd had a problem deploying to Storybook August 16, 2023 08:46 — with GitHub Actions Failure

ovflowd commented Aug 16, 2023

View reviewed changes

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

vercel bot deployed to Preview August 16, 2023 08:47 View deployment

ovflowd commented Aug 16, 2023

View reviewed changes

COLLABORATOR_GUIDE.md Outdated Show resolved Hide resolved

ovflowd commented Aug 16, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

ovflowd commented Aug 16, 2023

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

Apply suggestions from code review

28977fc

Signed-off-by: Claudio Wunder <[email protected]>

ovflowd deployed to Storybook August 16, 2023 08:48 — with GitHub Actions View deployment

vercel bot deployed to Preview August 16, 2023 08:49 View deployment

ovflowd requested a review from bmuenzenmeyer August 16, 2023 08:51

Merge branch 'main' into meta-updated-repo-structure

dc685aa

ovflowd deployed to Storybook August 16, 2023 08:52 — with GitHub Actions View deployment

vercel bot deployed to Preview August 16, 2023 08:53 View deployment

bmuenzenmeyer approved these changes Aug 16, 2023

View reviewed changes

ovflowd added this pull request to the merge queue Aug 16, 2023

Merged via the queue into main with commit 137f4d5 Aug 16, 2023

ovflowd deleted the meta-updated-repo-structure branch August 16, 2023 11:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: updated repo structure #5642

meta: updated repo structure #5642

ovflowd commented Aug 15, 2023 •

edited

Loading

vercel bot commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 15, 2023 •

edited

Loading

ovflowd commented Aug 15, 2023 •

edited

Loading

mikeesto left a comment

ovflowd commented Aug 16, 2023

bmuenzenmeyer commented Aug 16, 2023

ovflowd commented Aug 16, 2023

bmuenzenmeyer commented Aug 16, 2023

ovflowd commented Aug 16, 2023

meta: updated repo structure #5642

meta: updated repo structure #5642

Conversation

ovflowd commented Aug 15, 2023 • edited Loading

vercel bot commented Aug 15, 2023 • edited Loading

github-actions bot commented Aug 15, 2023 • edited Loading

Unit Test Coverage Report

Unit Test Report

github-actions bot commented Aug 15, 2023 • edited Loading

📦 Next.js Bundle Analysis for nodejs.org

ovflowd commented Aug 15, 2023 • edited Loading

mikeesto left a comment

Choose a reason for hiding this comment

ovflowd commented Aug 16, 2023

bmuenzenmeyer commented Aug 16, 2023

ovflowd commented Aug 16, 2023

bmuenzenmeyer commented Aug 16, 2023

ovflowd commented Aug 16, 2023

ovflowd commented Aug 15, 2023 •

edited

Loading

vercel bot commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 15, 2023 •

edited

Loading

github-actions bot commented Aug 15, 2023 •

edited

Loading

ovflowd commented Aug 15, 2023 •

edited

Loading