Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SVG logos on the download page #548

Merged
merged 1 commit into from
Mar 2, 2016
Merged

Use SVG logos on the download page #548

merged 1 commit into from
Mar 2, 2016

Conversation

silverwind
Copy link
Contributor

Replaced platform logos with SVG and use $node-green on them. Also updated the Windows logo in process:

cc: @jrit

@ghost
Copy link

ghost commented Mar 2, 2016

Travis build passed 👍

@ghost
Copy link

ghost commented Mar 2, 2016

LGTM

silverwind added a commit that referenced this pull request Mar 2, 2016
Use SVG logos on the download page
@silverwind silverwind merged commit c2c5bf7 into master Mar 2, 2016
@silverwind
Copy link
Contributor Author

Thanks!

@Trott
Copy link
Member

Trott commented Mar 2, 2016

Now if we could just get an SVG version of the new Node.js logo instead of an 1843x1129 PNG resized in CSS on the home page, WE'D BE GOLD!!!!!!!

(Not meant to disparage anyone or anything. I mean, it's not like I'm capable of creating an SVG myself without messing it up horribly. Nothing but respect. But uh, if someone wants to SVG-ize the Node logo, that would be great so long as the gradients don't cause the file size to be ridiculous. Or is that basically the problem with that approach?)

@Trott
Copy link
Member

Trott commented Mar 2, 2016

(Also, if we have a reasonable SVG version, maybe we can put it in the nodejs/node repo README for EXTRA PIZZAZZ!)

@silverwind
Copy link
Contributor Author

Yes +100, that downscaled scaled png logo is pure image abuse.

@mikeal do you have the original illustrator resource for the logo? If you could export that as svg, I can work on cutting it down to a reasonable size.

@stevemao stevemao deleted the svg-platforms branch March 3, 2016 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants